search

zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET
Other
2.95k stars 744 forks source link

Nullable reference types #878

Closed drewnoakes closed 4 years ago

drewnoakes commented 4 years ago

Annotates public API with C# 8 nullable reference types.

drewnoakes commented 4 years ago 
NetMQ.Tests.ZMTPTests.V2Test()
  √ NetMQ.Tests.NetworkOrderBitsConverterTests.TestInt16 [4ms]
  √ NetMQ.Tests.NetworkOrderBitsConverterTests.TestInt32 [1ms]
  √ NetMQ.Tests.NetworkOrderBitsConverterTests.TestInt64 [4ms]
  X NetMQ.Tests.ZMTPTests.V2Test [14ms]
  Error Message:
   Assert.Equal() Failure
Expected: Byte[] [5]
Actual:   Byte[] [5, 0, 0]
  Stack Trace:
     at NetMQ.Tests.ZMTPTests.V2Test() in /home/runner/work/netmq/netmq/src/NetMQ.Tests/ZMTPTests.cs:line 58

I can't see how these changes would influence any tests, let alone this one. Is this test flakey? Can we kick off another build somehow?

somdoron commented 4 years ago

Thanks!