search

zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET
Other
2.95k stars 744 forks source link

Remove reference assembly package references #882

Closed drewnoakes closed 4 years ago

drewnoakes commented 4 years ago

@somdoron I'm not sure what these were used for. Testing if CI passes without them. Hopefully they're not needed.

drewnoakes commented 4 years ago

/usr/share/dotnet/sdk/3.1.202/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.5 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/home/runner/work/netmq/netmq/src/NetMQ/NetMQ.csproj] /usr/share/dotnet/sdk/3.1.202/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.7 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/home/runner/work/netmq/netmq/src/NetMQ/NetMQ.csproj]

Seems they're needed for the Ubuntu CI environment. We could make them conditional on the CI property we added recently. What do you think?

somdoron commented 4 years ago

They are needed for Linux and OSX, however, they are development dependency only (PrivateAssets). I'm on Linux and OSX so I won't be able to compile without those.