search

zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET
Other
2.95k stars 744 forks source link

Run tests on debug builds #888

Closed drewnoakes closed 2 years ago

drewnoakes commented 4 years ago

@somdoron currently tests run with release builds. We have quite a few debug assertions in code that only run during debug builds. What would you say about running tests on debug builds so that these assertions are included?

The only downside I can see is that builds would be slower.

I am adding a trace listener that converts the assertion dialogs into exceptions, so there won't be any popups during CI.

somdoron commented 4 years ago

Sounds good to me. I'm thinking maybe to do both, as eventually, users are using the release version.

drewnoakes commented 4 years ago

895 contributes to this.

I'll look into setting up GitHub workflows (#891) that run tests in both debug and release.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions.