zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET
Other
2.95k stars 744 forks source link

Make System.Diagnostics.Debug failures throw in unit tests #895

Closed drewnoakes closed 4 years ago

drewnoakes commented 4 years ago

Previously, assertion failures while running unit tests would display a dialog box. This change causes an exception to be thrown instead.

This behaviour is beneficial on CI if debug builds are used.

The only downside is that locally it's a bit less convenient to investigate failures, as the 'retry' button allows quickly attaching a debugger with the offending frame in play.