search

zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET
Other
2.95k stars 744 forks source link

Migrated handling of Z85 encoding #918

Closed dxdjgl closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #918 into master will decrease coverage by 0.11%. The diff coverage is 76.38%.

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   65.68%   65.56%   -0.12%     
==========================================
  Files         148      148              
  Lines        9042     9114      +72     
  Branches     1461     1477      +16     
==========================================
+ Hits         5939     5976      +37     
- Misses       2497     2519      +22     
- Partials      606      619      +13
Impacted Files Coverage Δ
src/NetMQ/NetMQCertificate.cs 62.62% <76.38%> (+36.70%) :arrow_up:
src/NetMQ/NetMQConfig.cs 45.09% <0.00%> (-9.81%) :arrow_down:
src/NetMQ/Core/Patterns/Pair.cs 72.00% <0.00%> (-8.00%) :arrow_down:
src/NetMQ/Core/Transports/StreamEngine.cs 58.28% <0.00%> (-2.32%) :arrow_down:
src/NetMQ/Core/SessionBase.cs 71.85% <0.00%> (+1.48%) :arrow_up:
somdoron commented 4 years ago

Very nice

dxdjgl commented 4 years ago

@somdoron would it be possible to have a build made and also a build of Nacl.net as well? Sorry for bugging you.

somdoron commented 4 years ago

@dxdjgl just released a nacl version, if you can update NetMQ to use the latest version and I will merge it.

Also, if you would to join NetMQ maintainer that will be great, read our collaboration model here and let me know if you would like to join: https://rfc.zeromq.org/spec/42/

somdoron commented 4 years ago

https://www.nuget.org/packages/NaCl.Net/0.1.12

dxdjgl commented 4 years ago

@somdoron thank you very much for building the software. Regarding joining the NetMQ maintainer, what kind of commitment is expected. With a hectic everyday life work and private, I cannot commit to specific targets, however I am willing to pitch in from time to time, when my schedule allows it.

somdoron commented 4 years ago

It is mainly reviewing and merging pull requests. The project is pretty stable, so that is not much at the moment.

somdoron commented 4 years ago

Make sure not to merge your own, though.

Anyway I released a new pre-release version, it should be on nuget in a couple of minutes.

dxdjgl commented 4 years ago

Sign me up, and sure its not good practice to merge your own code.

somdoron commented 4 years ago

https://www.nuget.org/packages/NetMQ/4.0.1.3-pre