search

zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET
Other
2.95k stars 744 forks source link

Simplify .NET Framework conditional references #941

Closed eugbaranov closed 4 years ago

eugbaranov commented 4 years ago

Don't have to specify versions explicitly, can simply check for TargetFrameworkIdentifier instead.

codecov[bot] commented 4 years ago

Codecov Report

Merging #941 into master will increase coverage by 0.24%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
+ Coverage   65.93%   66.18%   +0.24%     
==========================================
  Files         148      148              
  Lines        8989     8989              
  Branches     1476     1476              
==========================================
+ Hits         5927     5949      +22     
+ Misses       2452     2430      -22     
  Partials      610      610
Impacted Files Coverage Δ
src/NetMQ/NetMQConfig.cs 45.09% <0.00%> (-9.81%) :arrow_down:
src/NetMQ/Core/Patterns/Pair.cs 72.00% <0.00%> (-8.00%) :arrow_down:
src/NetMQ/Core/SocketBase.cs 71.01% <0.00%> (+0.17%) :arrow_up:
src/NetMQ/Core/Transports/StreamEngine.cs 63.51% <0.00%> (+3.40%) :arrow_up:
src/NetMQ/Core/Utils/Poller.cs 79.26% <0.00%> (+3.65%) :arrow_up:
src/NetMQ/ReceiveThreadSafeSocketExtensions.cs 42.30% <0.00%> (+13.46%) :arrow_up: