search

zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET
Other
2.95k stars 744 forks source link

Default encoding should be UTF-8 as per standard (ref IETF RFC 7159) #943

Closed theonlynexus closed 2 years ago

theonlynexus commented 4 years ago

In page 9 of the RFC, there is the following paragraph:

"8.1. Character Encoding JSON text SHALL be encoded in UTF-8, UTF-16, or UTF-32. The default encoding is UTF-8, and JSON texts that are encoded in UTF-8 are interoperable[...]"

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions.

theonlynexus commented 2 years ago

No plans to merge?

theonlynexus commented 2 years ago

As mentioned in the conversation thread, I am closing the PR because in retrospect it seems rather non-sensical. Not sure what was going through my mind when I opened it.

drewnoakes commented 2 years ago

Thanks for following up. It's potentially a safe change, as UTF-8 is a superset of ASCII.

Ideally the API would change to require the caller to specify an Encoding when passing a string. We are careful about breaking APIs though.