search

zeromq / netmq

A 100% native C# implementation of ZeroMQ for .NET
Other
2.95k stars 744 forks source link

Multiple failing unit tests #959

Open jasells opened 3 years ago

jasells commented 3 years ago

Environment

NetMQ Version:    latest master branch (debug)
Operating System: Win10
.NET Version:     all

Expected behaviour

Unit tests run and pass

Actual behaviour

Many tests fail

Steps to reproduce the behaviour

Run unit tests.

Is this expected on the current master branch?

*update: it does appear to only occur for debug build, so I assume* that unit tests are not typically run in debug. The root of most of the failures seem to be the Assumes.NotNull() helper for asserts being misplaced. So, though it is not failing on release builds, it is possibly not executing as expected.

Example: NetMqPollerTest.RemoveSocket() hits M-handle null check before it is ever created:

public virtual void SetAddress(string addr)
        {
            m_address.Resolve(addr, m_options.IPv4Only);

            Assumes.NotNull(m_address.Address);
            Assumes.NotNull(m_handle);

            try
            {
                m_handle = AsyncSocket.Create(m_address.Address.AddressFamily, SocketType.Stream, ProtocolType.Tcp);

Src link.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions.