zeromq / pyre

Python port of Zyre
GNU Lesser General Public License v3.0
121 stars 52 forks source link

mirror new functionality in zyre #92

Open sphaero opened 8 years ago

sphaero commented 8 years ago

see: https://github.com/zeromq/zyre/pull/466/commits/26417ce291d90b30de073da1e5bcab3c55e74059

papr commented 8 years ago

Does this include removing Zre_msg.py—since it seems to follow an deprecated protocol version (at least for incoming notifications)—and replacing it with an appropriate PyreEvent class, mirroring https://github.com/zeromq/zyre/blob/master/src/zyre_event.c?

sphaero commented 8 years ago

No, although it would be nice to add a PyreEvent class.

I don't understand what you mean that zre_msg follows a deprecated protocol version. Zre_msg only encodes and decodes the raw wire data. ZyreEvent is just an addition, you don't need to use it, it's just a convenience class.