zeromq / pyzmq

PyZMQ: Python bindings for zeromq
http://zguide.zeromq.org/py:all
BSD 3-Clause "New" or "Revised" License
3.65k stars 637 forks source link

Changed openssh password prompt regex + Added max number of retries ; fix #1904 #1905

Closed KenyC closed 10 months ago

KenyC commented 10 months ago

My ssh doesn't have the password prompt pyzmq expects, which triggers infinite looping (as described in #1904).

> ssh -f 123.123.123.123 -i /path/to/my/key/
Enter passphrase for key '/path/to/my/key/': 
> ssh -V
OpenSSH_8.9p1 Ubuntu-3ubuntu0.4, OpenSSL 3.0.2 15 Mar 2022

I changed the pattern from pass(word|phrase): to pass(word|phrase) to account for my ssh.

I also added a max number of retry to avoid infinite looping, in case future updates also change the phrasing of password prompts.

closes #1904

minrk commented 10 months ago

Thanks!