search

zeromq / pyzmq

PyZMQ: Python bindings for zeromq
http://zguide.zeromq.org/py:all
BSD 3-Clause "New" or "Revised" License
3.69k stars 637 forks source link

tests: using await for on_send(), on_recv() with ZMQStream #1972

Closed spchamp closed 6 months ago

spchamp commented 6 months ago

Update: This patch may be an artifact of an incomplete test installation. pytest_asyncio was not installed under the initial testing environment. This may have resulted in the test failure I'd seen.

Maybe it's possible to await some things related to a tornado IO loop, this patch might not in fact be the right approach though

spchamp commented 6 months ago

Testing this again with the unpatched sources now that pytest_asyncio is installed, the tests pass. I'll delete this branch shortly.