zeromq / pyzmq

PyZMQ: Python bindings for zeromq

http://zguide.zeromq.org/py:all

BSD 3-Clause "New" or "Revised" License

3.62k stars 635 forks source link

Update wheels.yml to prevent release if failed builds. #1979

Closed markclare1992 closed 2 months ago

markclare1992 commented 3 months ago

Add check for all wheels building successfully before uploading to PyPI. Not sure if this step should happen immediately after wheel building step or where I have put it?

markclare1992 commented 3 months ago

Linked to https://github.com/zeromq/pyzmq/issues/1978

minrk commented 3 months ago

Thanks for the PR! This is already accomplished by the needs field, I believe (the affected step didn't run until just now when all the jobs finished). The problem is linux ARM wheels are published from CircleCI.

If we added a step that pulled the wheels in from Circle so that only GitHub did the upload, it would fix this.

minrk commented 2 months ago

1982 causes all wheels to be uploaded together