Minor build improvements

zeromq / zeromq.js

:zap: Node.js bindings to the ØMQ library

http://zeromq.github.io/zeromq.js/

MIT License

1.46k stars 211 forks source link

Minor build improvements #614

Closed rotu closed 3 months ago

rotu commented 3 months ago

Don't skip tsc on install script. Previously, if script/build.js exists, we would skip the C++ build.
Fix issue with github tags if ZMQ version provided as semver. (github seems to normalize tarballed directory name by stripping leading v from tag)
Build scripts before node-gyp. Build library wrappers after.

Removed from this PR:

~~Remove questionable .npmrc~~
~~Switch to standard node-gyp-build. Modified version tends to hang on failure instead of crash.~~

rotu commented 3 months ago

Please change the title of the pull request to follow the Code of Conduct. We want to have a friendly environment here in Zeromq https://zeromq.org/community/code-of-conduct/

I'm sorry if my words or tone seemed like trolling or like a personal attack! I don't at all mean to antagonize you or anyone else who pours selfless hours into open source software. I intended it to be levity over how frustrating it is to get a stable build process and an allusion to the frustrated confusion in recent issues.

Thank you for the tone reminder. I'll try to be more constructive with my wording in the future!