Draft support not enabled by default

zeromq / zeromq.js

:zap: Node.js bindings to the ØMQ library

http://zeromq.github.io/zeromq.js/

MIT License

1.42k stars 204 forks source link

Draft support not enabled by default #638

Open antoniaelsen opened 3 days ago

antoniaelsen commented 3 days ago

Describe the bug A clear and concise description of what the bug is.

ZMQ Draft support is not enabled by default in builds, despite the suggestion in the README

Quick ref: https://github.com/zeromq/zeromq.js/blob/f9ee2a3e2c39f63874da29b4ed10df460a33e500/.github/workflows/CI.yml#L64 https://github.com/zeromq/zeromq.js/blob/f9ee2a3e2c39f63874da29b4ed10df460a33e500/binding.gyp#L4

Is the README technically incorrect or should the build scripts & config be updated? Can submit a PR to correct either way.

aminya commented 3 days ago

The draft is not enabled in the latest release yet. I plan to enable it in the upcoming release. The readme shows the dev status.

antoniaelsen commented 2 days ago

@aminya are the cli / .npmrc --zmq-draft and --build-from-source flags expected to work? I'm not convinced the zmq lib is being rebuilt when I'm using them, and when trying to use draft features (RADIO/DISH), I get

Error: ZeroMQ draft features are not enabled in this build. To enable support, (re)compile this library with --zmq-draft.

If this isn't expected, I can create a new issue and include more details (but succinctly: arm osx 13, node 20)