zeromq / zeromq3-x

ØMQ/3.2 release branch - bug fixes only
GNU General Public License v3.0
227 stars 96 forks source link

CMake build not working on Linux #94

Open thinxer opened 11 years ago

thinxer commented 11 years ago

As I am using CMake to manage my project, it is good to integrate the CMake building process into my project. However, the CMake file contains several errors which make it impossible to compile. Please fix.

Gregwar commented 11 years ago

I confirm that it seems weird, for instance why these flags are used since it really look like a windows thing?

# Optimization flags.
# http://msdn.microsoft.com/en-us/magazine/cc301698.aspx
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /GL")
set(CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE} /LTCG")
set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} /LTCG")
set(CMAKE_MODULE_LINKER_FLAGS_RELEASE "${CMAKE_MODULE_LINKER_FLAGS_RELEASE} /LTCG")
thinxer commented 11 years ago

Yes. I suspect the CMakeLists.txt is used only for the Windows build.

I prefer CMake to autotools for managing a cross platform project.

On Thu, Jul 4, 2013 at 9:30 PM, Grégoire Passault notifications@github.comwrote:

I confirm that it seems weird, for instance why these flags are used since it really look like a windows thing?

Optimization flags.

http://msdn.microsoft.com/en-us/magazine/cc301698.aspx

set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /GL") set(CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE} /LTCG") set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} /LTCG") set(CMAKE_MODULE_LINKER_FLAGS_RELEASE "${CMAKE_MODULE_LINKER_FLAGS_RELEASE} /LTCG")

— Reply to this email directly or view it on GitHubhttps://github.com/zeromq/zeromq3-x/issues/94#issuecomment-20477132 .

thinxer commented 11 years ago

Well, are there any updates to this issue?

hintjens commented 11 years ago

Hi Jlanfei,

Please make any patches you need to against the libzmq master, and discuss on zeromq-dev. Thanks

-Pieter

On Wed, Sep 4, 2013 at 3:44 AM, Jianfei Wang notifications@github.comwrote:

Well, are there any updates to this issue?

— Reply to this email directly or view it on GitHubhttps://github.com/zeromq/zeromq3-x/issues/94#issuecomment-23760598 .