zeromq / zeromq4-x

ØMQ 4.x stable release branch - bug fixes only
GNU General Public License v3.0
458 stars 196 forks source link

Add missing newline to test_proxy_terminate.cpp to fix compiling with… #120

Closed junovitch closed 9 years ago

junovitch commented 9 years ago

… Clang's -Werror,-Wnewline-eof

junovitch commented 9 years ago

This resolves the following error seen at compile time with Clang 3.6 on FreeBSD 11-CURRENT and Clang 3.4.1 on FreeBSD 10.1-RELEASE.

c++ -DHAVE_CONFIG_H -I. -I../src -I../include -I../include -pedantic -Werror -Wall -D__BSD_VISIBLE -D_REENTRANT -D_THREAD_SAFE -I/usr/local/include -DZMQ_FORCE_KQUEUE -O2 -pipe -Wno-long-long -fstack-protector -fno-strict-aliasing -MT test_proxy_terminate.o -MD -MP -MF .deps/test_proxy_terminate.Tpo -c -o test_proxy_terminate.o test_proxy_terminate.cpp test_proxy_terminate.cpp:113:2: error: no newline at end of file [-Werror,-Wnewline-eof] } ^ 1 error generated. *\ Error code 1

This also resolves the following compile time error seen with GCC on FreeBSD 8.4-RELEASE

c++ -DHAVE_CONFIG_H -I. -I../src -I../include -I../include -pedantic -Werror -Wall -D__BSD_VISIBLE -D_REENTRANT -D_THREAD_SAFE -I/usr/local/include -DZMQ_FORCE_KQUEUE -O2 -pipe -Wno-long-long -fstack-protector -fno-strict-aliasing -MT test_proxy_terminate.o -MD -MP -MF .deps/test_proxy_terminate.Tpo -c -o test_proxy_terminate.o test_proxy_terminate.cpp test_proxy_terminate.cpp:113:2: error: no newline at end of file

hintjens commented 9 years ago

Does this also apply to libzmq?

For any change to a stable release we need an issue, so could you create one if there's not one that covers this? Thanks.

junovitch commented 9 years ago

Both zeromq/libzmq and zeromq/zeromq4-1 were fine. This appear to only be in zeromq4-x, perhaps a copy/paste mishap. I will double check other releases as well and ensure they are all good.

Will open an issue and update this later with details. Thank you for the quick feedback.