search

zeromq / zmqpp

0mq 'highlevel' C++ bindings
http://zeromq.github.io/zmqpp
Mozilla Public License 2.0
438 stars 197 forks source link

Fix error in test. #117

Closed xaqq closed 9 years ago

xaqq commented 9 years ago

This fixes #116. Problem: The creation of the zmq_pollitem_t object had a typo, resulting in a call to zmq_poll() that didn't really make sense. Solution: Correctly create the pollitem and adjust the BOOT_CHECK call to a proper expected result. Also increase the max timeout to 1second to make sure the message as plenty of time to be delivered.

benjamg commented 9 years ago

Although it would be nice to have less slow tests rather than slower ones :)

xaqq commented 9 years ago

Oh don't worry this is the maximum timeout before the test fails. The test would be slower only in worst case scenario (where it would previously had failed). It will still be instantaneous on most hardware.

On Tue, Jun 2, 2015 at 1:21 PM, Ben Gray notifications@github.com wrote:

Although it would be nice to have less slow tests rather than slower ones :)

— Reply to this email directly or view it on GitHub https://github.com/zeromq/zmqpp/pull/117#issuecomment-107918860.

Kapp Arnaud - Xaqq