Windows static LIB build

zeromq / zmqpp

0mq 'highlevel' C++ bindings

http://zeromq.github.io/zmqpp

Mozilla Public License 2.0

438 stars 197 forks source link

Windows static LIB build #152

Open harsszegi opened 8 years ago

harsszegi commented 8 years ago

Hello,

missing proper zmq.hpp setup when building the static library, missing ZMQ_STATIC define. Please modify CMakeLists.txt like this:

if (ZMQPP_BUILD_STATIC) add_library( zmqpp-static STATIC ${LIBZMQPP_SOURCES}) add_definitions(-DZMQ_STATIC) target_link_libraries(zmqpp-static ZeroMQ::libzmq-static) list( APPEND INSTALL_TARGET_LIST zmqpp-static) set( LIB_TO_LINK_TO_EXAMPLES zmqpp-static ) endif() # ZMQPP_BUILD_STATIC

Thanks,

whatisgravity commented 8 years ago

You should fork the project and make the change then issue a pull request. It would get implemented faster.

tatraian commented 8 years ago

I think this has been fixed during #151. So you can close this as well. Can I ask a new release from the latest version. I would like to put it into hunter. Thanks.