search

zeromq / zmqpp

0mq 'highlevel' C++ bindings
http://zeromq.github.io/zmqpp
Mozilla Public License 2.0
438 stars 195 forks source link

Feature/orig windows dll enum #157

Closed benjamg closed 8 years ago

benjamg commented 8 years ago

Fixes for cmake and linux builds based on the work @tatraian did for #156. Could do with being tested in Windows as well but travis is finally passing again

xaqq commented 8 years ago

So if I understand correctly, #156 should be closed and we should merge this one. Could you rebase and force-push before we merge this so we can have a little bit cleaner history?

PS: enum seems like a good idea.

benjamg commented 8 years ago

Squashed the cmake/travis commits and gave it a more sensible comment.

benjamg commented 8 years ago

I do like how some of the Travis tests seem to fail and others don't while doing the same install code at the start :(

xaqq commented 8 years ago

I do like how some of the Travis tests seem to fail and others don't while doing the same install code at the start :(

Particularly surprising is that it seems apt is failing. Should I go ahead and merge this and we investigate those Travis issues later?

benjamg commented 8 years ago

sounds sensible to me