Add function unmonitor to zmqpp::socket

zeromq / zmqpp

0mq 'highlevel' C++ bindings

http://zeromq.github.io/zmqpp

Mozilla Public License 2.0

438 stars 195 forks source link

Add function unmonitor to zmqpp::socket #178

Closed pinchal closed 7 years ago

pinchal commented 7 years ago

Sockets can be unmonitored. This is not mentioned in documentation (which is pretty unclear), but the feature is implemented (https://github.com/zeromq/libzmq/blob/master/src/socket_base.cpp#L1592).

This merge add:

the function zmqpp::socket::unmonitor,
the event zmqpp::event::monitor_stopped (which is sent when unmonitor is called),
test for unmonitor in test_socket.cpp.

xaqq commented 7 years ago

Hello, thank you for this patch. It looks good. I wasn't aware of this feature, and probably a lot of users aren't either. I'm pretty sure libzmq would merge a documentation patch regarding the documentation of this "unmonitor" feature.

pinchal commented 7 years ago

You're welcome.

I have a very tricky issue on libzmq when a monitored socket is destroyed (something that randomly makes all other ipc sockets to freeze). I plan to open a ticket on libzmq but I have to look deeper, meanwhile unmonitor sockets before destruction avoid the problem.