search

zeromq / zmqpp

0mq 'highlevel' C++ bindings
http://zeromq.github.io/zmqpp
Mozilla Public License 2.0
438 stars 197 forks source link

zmqpp::socket::receive_raw also has int length #53

Closed cmdevries closed 10 years ago

cmdevries commented 10 years ago

As with my previous pull request for send_raw, the buffer for receive_raw has an int for length rather than a size_t. I added unit tests for testing sending >2GB messages using zmqpp::socket and now something failings inside ZMQ. It returns with EAGAIN.

benjamg commented 10 years ago

This can't be automatically merged, I assume because this request reapplies the change;

-bool socket::sendraw(char const* buffer, int const length, int const flags /* = NORMAL /) +bool socket::sendraw(char const buffer, size_t const length, int const flags /* = NORMAL */)

cmdevries commented 10 years ago

This changeset adds a unit test that still fails. But it happens somewhere inside ZMQ 3.2.x. Do you see any problems with leaving it this way?

cmdevries commented 10 years ago

Are there still any issues with merging in the second commit?

hintjens commented 10 years ago

You should rebase your fork off master.

On Tue, Jun 10, 2014 at 9:49 AM, Chris De Vries notifications@github.com wrote:

Are there still any issues with merging in the second commit?

— Reply to this email directly or view it on GitHub https://github.com/zeromq/zmqpp/pull/53#issuecomment-45583453.

cmdevries commented 10 years ago

Everything is now up to date with upstream and should merge without issues.