Problem: Android generated code has inconsistent dependency ROOT variable names. - Githubissues

zeromq / zproject

CLASS Project Generator

Mozilla Public License 2.0

148 stars 104 forks source link

Problem: Android generated code has inconsistent dependency ROOT variable names. #1323

Closed stephan57160 closed 1 year ago

stephan57160 commented 1 year ago

Some generated scripts are built with $(USE.PROJECT)_ROOT and some others are built with $(USE.LIBNAME)_ROOT

This inconsistency is not seen with CZMQ.

With ZYRE, this gives (for instance):

bindings/jni/ci_build.sh set LIBCZMQ_ROOT:

android_init_dependency_root "libczmq" # Check or initialize LIBCZMQ_ROOT
builds/android/build.sh expects CZMQ_ROOT:

if [ ! -d "${CZMQ_ROOT}" ] ; then

Solution: Replace $(USE.LIBNAME)_ROOT by $(USE.PROJECT)_ROOT and similar.

Important:

This will affect ZYRE, when using recent commits, and especially like below:

export LIBCZMQ_ROOT=xxx
cd bindings/jni/zyre-jni/android/build.sh:
./build.sh [arm|arm64|x86|x86_64]

The same call becomes:

export CZMQ_ROOT=xxx
cd bindings/jni/zyre-jni/android/build.sh:
./build.sh [arm|arm64|x86|x86_64]

or similar with bindings/jni/ci_build.sh.

Note:

USE.LIBNAME was mistakenly introduced in a recent PR of mine.