search

zeroone2numeral2 / reddit-test

3 stars 1 forks source link

Do not remove file when it's too big #59

Closed RememberTheAir closed 5 years ago

RememberTheAir commented 5 years ago

No need to remove the file when it's too big, because it will be done by the remove method of the downloader object

See the following log:

[2019-04-09 16:19:04,701][bot.jobs.post:74][INFO] >>> ...submission bb89of has NOT been posted yet, we will post this one if it passes checks
[2019-04-09 16:19:04,701][reddit.sender:108][DEBUG] >>> url is a vreddit
[2019-04-09 16:19:04,993][bot.jobs.post:116][INFO] >>> submission passed filters
[2019-04-09 16:19:04,994][bot.jobs.post:127][INFO] >>> submission url: https://v.redd.it/n70picbbv8r21
[2019-04-09 16:19:04,995][bot.jobs.post:128][INFO] >>> submission title: Simple misunderstanding [Sakurasou]
[2019-04-09 16:19:04,996][reddit.sender:203][INFO] >>> post is a media, sending it as media...
[2019-04-09 16:19:04,997][reddit.sender:209][INFO] >>> post is a vreddit: using _send_vreddit()
[2019-04-09 16:19:04,997][reddit.sender:253][INFO] >>> vreddit url: https://v.redd.it/n70picbbv8r21/DASH_1080?source=fallback
[2019-04-09 16:19:05,038][reddit.sender:256][INFO] >>> vreddit video url: https://v.redd.it/n70picbbv8r21/DASH_1080?source=fallback
[2019-04-09 16:19:05,039][reddit.sender:257][INFO] >>> vreddit audio url: https://v.redd.it/n70picbbv8r21/audio
[2019-04-09 16:19:05,040][reddit.sender:264][INFO] >>> file that will be used for the merged audio/video: downloads/bb89of_merged.mp4
[2019-04-09 16:19:05,040][reddit.sender:266][INFO] >>> downloading video/audio and merging them...
[2019-04-09 16:19:05,041][reddit.sender:271][INFO] >>> video is too big to be sent (54.38 mb), removing file and sending text...
[2019-04-09 16:19:05,041][reddit.downloaders.vreddit:67][INFO] >>> removing downloads/bb89of.mp4...
[2019-04-09 16:19:05,042][reddit.downloaders.vreddit:72][ERROR] >>> ...downloads/bb89of.mp4 not removed: FileNotFoundError
[2019-04-09 16:19:05,042][reddit.downloaders.vreddit:67][INFO] >>> removing downloads/bb89of.mp3...
[2019-04-09 16:19:05,043][reddit.downloaders.vreddit:72][ERROR] >>> ...downloads/bb89of.mp3 not removed: FileNotFoundError
[2019-04-09 16:19:05,043][reddit.downloaders.vreddit:67][INFO] >>> removing downloads/bb89of_merged.mp4...
[2019-04-09 16:19:05,044][reddit.downloaders.vreddit:72][ERROR] >>> ...downloads/bb89of_merged.mp4 not removed: FileNotFoundError
[2019-04-09 16:19:05,044][reddit.downloaders.vreddit:67][INFO] >>> removing ...
[2019-04-09 16:19:05,045][reddit.downloaders.vreddit:72][ERROR] >>> ... not removed: FileNotFoundError
[2019-04-09 16:19:05,045][reddit.sender:223][ERROR] >>> exeption during the sending of a media, sending as text. Error:
Traceback (most recent call last):
  File "/root/reddit-test/reddit/sender.py", line 267, in _send_vreddit
    file_path = vreddit.download_and_merge(skip_audio=True if self._s.is_gif else False)
  File "/root/reddit-test/reddit/downloaders/vreddit.py", line 134, in download_and_merge
    self.download()
  File "/root/reddit-test/reddit/downloaders/generic.py", line 71, in download
    self.check_size()
  File "/root/reddit-test/reddit/downloaders/generic.py", line 64, in check_size
    raise FileTooBig('file size is too big for Telegram: {}'.format(self._size_readable))
reddit.downloaders.generic.FileTooBig: file size is too big for Telegram: 54.38 mb

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/reddit-test/reddit/sender.py", line 210, in post
    self._sent_message = self._send_vreddit(self._s.media_url, text)
  File "/root/reddit-test/reddit/sender.py", line 273, in _send_vreddit
    raise FileTooBig
reddit.downloaders.generic.FileTooBig
RememberTheAir commented 5 years ago

Not a bug