zeropingheroes / lancache-autofill

Automatically fill a Lancache with content
GNU General Public License v3.0
132 stars 25 forks source link

updating app list using a file of steam64ids keeps crashing #25

Closed billthecatt closed 5 years ago

billthecatt commented 6 years ago

Please see below, i start steam:queue-users-recent-apps three times, each time it does something different and then crashes

./lancache-autofill steam:queue-users-recent-apps ~/steam64s.txt

Queuing apps recently played by user: Sheepdog-- Steam app "Counter-Strike: Global Offensive" on platform "Windows" already in download queue Steam app "Half-Life 2: Deathmatch" on platform "Windows" already in download queue Steam app "Insurgency" on platform "Windows" already in download queue Steam app "Rise of Nations: Extended Edition" on platform "Windows" already in download queue Steam app "Team Fortress 2" on platform "Windows" already in download queue Steam app "Torchlight II" on platform "Windows" already in download queue

In Player.php line 114:

Undefined property: stdClass::$total_count

user1@srv02:~/lancache-autofill$ ./lancache-autofill steam:queue-users-recent-apps ~/steam64s.txt

Queuing apps recently played by user: billcat-actual Steam app "Artemis Spaceship Bridge Simulator" on platform "Windows" already in download queue Steam app "Counter-Strike: Global Offensive" on platform "Windows" already in download queue Steam app "Day of Infamy" on platform "Windows" already in download queue Steam app "Half-Life 2: Deathmatch" on platform "Windows" already in download queue Steam app "Insurgency" on platform "Windows" already in download queue Steam app "Insurgency: Sandstorm" on platform "Windows" already in download queue Steam app "Left 4 Dead 2" on platform "Windows" already in download queue Steam app "Team Fortress 2" on platform "Windows" already in download queue Steam app "Torchlight II" on platform "Windows" already in download queue Steam app "War Thunder" on platform "Windows" already in download queue

Skipping user with private profile: Fellow_Comrade

In Player.php line 114:

Undefined property: stdClass::$total_count

user1@srv02:~/lancache-autofill$ ./lancache-autofill steam:queue-users-recent-apps ~/steam64s.txt

Skipping user who has not recently played any apps: Briggins

Queuing apps recently played by user: Fallon Steam app "Counter-Strike: Global Offensive" on platform "Windows" already in download queue Steam app "Half-Life 2: Deathmatch" on platform "Windows" already in download queue Steam app "Insurgency" on platform "Windows" already in download queue Steam app "Team Fortress 2" on platform "Windows" already in download queue Steam app "Torchlight II" on platform "Windows" already in download queue

Queuing apps recently played by user: effectontarget Steam app "Counter-Strike: Global Offensive" on platform "Windows" already in download queue

Queuing apps recently played by user: Bulldozer Steam app "Counter-Strike: Global Offensive" on platform "Windows" already in download queue Steam app "Insurgency" on platform "Windows" already in download queue Steam app "Rise of Nations: Extended Edition" on platform "Windows" already in download queue Steam app "Team Fortress 2" on platform "Windows" already in download queue Steam app "Torchlight II" on platform "Windows" already in download queue

In Player.php line 114:

Undefined property: stdClass::$total_count

Here is my steam64s.txt just in case something unique to it is causing the crashes: 76561197983046600 76561197983776334 76561198245482754 76561198301326570 76561198302077492 76561198346409836 76561198351407264 76561198001428348 76561198001472830 76561198402549776 76561198018697958 76561198018994882 76561198024592438 76561198055837230 76561197970641022 76561198073291294 76561198095737978 76561197960405992 76561197961778882 76561198150384700 76561198160972095 76561198254514327 76561198273849513 76561198288247437 76561198402036511 76561198005563723 76561198008857699 76561198014207351 76561198016886069 76561198018827975 76561198024092545 76561198819570015 76561197970845665 76561197961919301

I'm not solid enuf in PHP to sort out what's going on wrong on line 114 so I'm hopeful something about this makes sense to someone.

Thanks for a great project. This program really helps me pre-populate the cache correctly and have the content my users want when they show up. TYVM!

billthecatt commented 6 years ago

I was able to work around this issue using a bash script:

!/bin/bash

./lancache-autofill steam:queue-users-recent-apps ~/steam64s.txt

for word in $(cat ~/steam64s.txt); do ./lancache-autofill steam:queue-users-recent-apps $word; done

You can close this issue afaic, I'll just keep using the ID method instead of the file method. Hope this bash one-liner helps someone else.

Thanks!

ilumos commented 6 years ago

Thanks for this.

Looked into it, and it's due to a bug in an upstream repo, which I've opened a PR for

I'll keep this issue open until they've fixed.

billthecatt commented 6 years ago

I think something is up here with some of the SteamIDs in my list. Something about them causes the process to fail, ungracefully. In any case, using the list I've provided, you should be able to reproduce it easily.

ilumos commented 6 years ago

Yes, any profile which has private gameplay data will have this issue

https://github.com/syntaxerrors/Steam/pull/80

ilumos commented 5 years ago

Fixed as of 4th March by https://github.com/syntaxerrors/Steam/releases/tag/2.0.15