search

zeropingheroes / lancache-autofill

Automatically fill a Lancache with content
GNU General Public License v3.0
132 stars 24 forks source link

Add `steam:queue-users-owned-apps` command for queueing all games for a user #54

Closed jdmcmahan closed 3 years ago

jdmcmahan commented 3 years ago

This PR adds the ability for a user to automatically enqueue all owned games with a single command. This is done in the same way as steam:queue-users-recent-apps except with a call to GetOwnedGames() instead of GetRecentlyPlayedGames().

Note that this PR does not attempt to refactor/combine duplicate code between QueueUsersRecentApps and QueueUsersOwnedApps as the opportunity extends to a few existing classes.

Fixes #49. Fixes #53. I was interested in this functionality as well and decided to give it a go.

billthecatt commented 3 years ago

This seems really good, could someone please integrate it into the full project so we can all use it?

billthecatt commented 3 years ago

Hey, this is really good code. Thanks for sharing it with us.

I thought the --include_free=true function would let me queue only the free apps. I'm trying to queue as much of the free content as my lan attendees have subscribed to, so that when they start downloading them from my otherwise fast cache, it won't go out to the internet to download it.

That said, could you do something like --include_paid=false or --only_include_free=true so that we could fill the cache with all the free content our users use?

Thanks in advance for considering this feature request..

jdmcmahan commented 3 years ago

@billthecatt I like this idea as well. I went ahead and created a new issue for this feature.

Disclaimer - I'm not a maintainer of this project, but I'm interested to see where it goes. Unfortunately, it doesn't seem like this project has been active in over a year. I'd certainly be willing to contribute if the maintainers are looking for help.

billthecatt commented 3 years ago

Your disclaimer makes sense.. And that's what I'm seeing as well. I think you did the right thing to make a fork and keep working on it on your own. You may become the latest/only active maintainer of this going forward, if it's not going to be updated in this git.. that said, looking forward to seeing this feature in your git. :)

jdmcmahan commented 3 years ago

@billthecatt FYI I took a stab at this in #56. It's a bit slow because an additional API call has to be made for each app to determine whether the app is f2p. There seems to be a bug in the Steam API which prevents getting all the data in one request.

Let me know what you think!

jdmcmahan commented 3 years ago

Closing this PR to source from a non-master branch.

New PR is #58.