search

zeropwn / intelx.py

Python API Wrapper and command-line utility for intelx.io
31 stars 10 forks source link

Removing Storage ID from cli #1

Closed Kleissner closed 4 years ago

Kleissner commented 4 years ago

The -sid (storageid) parameter should be removed. To prevent any confusion: sid on intelx.io is actually the system ID which is unique to the search result.

If a user wants to view a document, they should do it through the regular search function which supports System IDs. E.g.: https://intelx.io/?s=29a97791-1138-40b3-8cf1-de1764e9d09c

When the regular search for a System ID is used, the advantage is that all the metadata is available (for choosing the right format to preview or view the result).

After removing the -sid param the following parameters become meaningless and should be also removed: --pdf, --hex, --word, --preview, --view.

Instead the --view[s] parameter should be added for the regular search (like we have now the --previews switch).

Kleissner commented 4 years ago

Fixed in 0a0d6bc2902d1c6a84064beda0e8fe63fa035d15 and f