zerospam / laravel-gettext

Adds localization support to laravel applications using PoEdit and GNU-Gettext.
99 stars 56 forks source link

Make Laravel 5.7 Compatible official #18

Closed codiiv closed 5 years ago

codiiv commented 5 years ago

Laravel 5.7 came out 2 days ago and I just tested and it works fine. Maybe update the documentation accordingly?

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 55.989% when pulling 72b8e246c0937c9a5ca3b084a227025464ddc966 on codiiv:patch-1 into 2da7591034be06e59bbd4fc93da2019a3f33308a on Belphemur:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 55.989% when pulling 72b8e246c0937c9a5ca3b084a227025464ddc966 on codiiv:patch-1 into 2da7591034be06e59bbd4fc93da2019a3f33308a on Belphemur:master.

LuXIN commented 5 years ago

I need Laravel 5.7 too, could it be merged please ?

Belphemur commented 5 years ago

It isn't needed to make the project work with 5.7.

I just need to update the Readme. You can already use the package without issues.


From: Lulu notifications@github.com Sent: Thursday, December 20, 2018 05:48 To: Belphemur/laravel-gettext Cc: Subscribed Subject: Re: [Belphemur/laravel-gettext] Make Laravel 5.7 Compatible official (#18)

I need Laravel 5.7 too, could it be merged please ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

LuXIN commented 5 years ago

And composer.json ?

"laravel/framework": "^5.6"

Belphemur commented 5 years ago

^5.6 means minimum 5.6

I'm already using the lib in a 5.7 project without needing to change the composer.json


From: Lulu notifications@github.com Sent: Thursday, December 20, 2018 06:52 To: Belphemur/laravel-gettext Cc: Antoine Aflalo; Comment Subject: Re: [Belphemur/laravel-gettext] Make Laravel 5.7 Compatible official (#18)

And composer.json ?

"laravel/framework": "^5.6"

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

LuXIN commented 5 years ago

You are right ! It works ! Thank you