Closed codiiv closed 5 years ago
I need Laravel 5.7 too, could it be merged please ?
It isn't needed to make the project work with 5.7.
I just need to update the Readme. You can already use the package without issues.
From: Lulu notifications@github.com Sent: Thursday, December 20, 2018 05:48 To: Belphemur/laravel-gettext Cc: Subscribed Subject: Re: [Belphemur/laravel-gettext] Make Laravel 5.7 Compatible official (#18)
I need Laravel 5.7 too, could it be merged please ?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
And composer.json ?
"laravel/framework": "^5.6"
^5.6 means minimum 5.6
I'm already using the lib in a 5.7 project without needing to change the composer.json
From: Lulu notifications@github.com Sent: Thursday, December 20, 2018 06:52 To: Belphemur/laravel-gettext Cc: Antoine Aflalo; Comment Subject: Re: [Belphemur/laravel-gettext] Make Laravel 5.7 Compatible official (#18)
And composer.json ?
"laravel/framework": "^5.6"
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
You are right ! It works ! Thank you
Laravel 5.7 came out 2 days ago and I just tested and it works fine. Maybe update the documentation accordingly?