Theme Tweaks - Githubissues

zerostaticthemes / hugo-hero-theme

A multi-page Hugo theme with fullscreen hero images and fullwidth sections.

https://hugo-hero.netlify.com

MIT License

355 stars 252 forks source link

Theme Tweaks #28

Closed zwbetz-gh closed 3 years ago

zwbetz-gh commented 3 years ago

Hey there. I recently used your hero theme on a side project. (Out of all the available hugo themes, they picked yours based on the design, so props).

Made a few tweaks when implementing it, so thought I'd give back. Thanks for making this theme 👍

Changes:

Allow custom css files by accepting an array of assets dir file paths
Allow contact page address to enter and show newlines
Allow contact page business hours to be specified in config, not hardcoded in template

zwbetz-gh commented 3 years ago

Was looking through the open issues. Looks like this PR would partially address https://github.com/zerostaticthemes/hugo-hero-theme/issues/22

zwbetz-gh commented 3 years ago

Bump

JugglerX commented 3 years ago

@zwbetz-gh sorry for the delay mate. Thank you so much for the PR.

I like what you've added for the contact page.

Can you explain the use case/advantage of the custom css? Isn't it just as easy to add a new @import to the style.scss?

zwbetz-gh commented 3 years ago

I prefer working with CSS over SCSS because I'm a bit old-school. But fair point. Someone could just edit the style.scss. I'll remove the custom CSS config changes from this PR.

zwbetz-gh commented 3 years ago

Removed in https://github.com/zerostaticthemes/hugo-hero-theme/pull/28/commits/406ec59bc9a8cd4cd03da97aa35e025c51cab79a

Now just the Contact page changes remain.