search

zerothi / sisl

Electronic structure Python package for post analysis and large scale tight-binding DFT/NEGF calculations
https://zerothi.github.io/sisl
Mozilla Public License 2.0
182 stars 58 forks source link

changed phonon displacement shape #763

Closed zerothi closed 5 months ago

zerothi commented 5 months ago

@nils-wittemeier and @monx-ne I am planning on changing this for consistencies.

What do you think of this re-ordering of the shapes? It seems more natural to me?

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.85%. Comparing base (e881fda) to head (d8afc91).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #763 +/- ## ========================================== + Coverage 86.83% 86.85% +0.02% ========================================== Files 410 410 Lines 51822 51826 +4 ========================================== + Hits 44999 45013 +14 + Misses 6823 6813 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nils-wittemeier commented 5 months ago

I am in favor of this change. It is much more natural.

zerothi commented 5 months ago

That's good enough for me!