search

zerothi / sisl

Electronic structure Python package for post analysis and large scale tight-binding DFT/NEGF calculations
https://zerothi.github.io/sisl
Mozilla Public License 2.0
182 stars 58 forks source link

Add support for sisl in nodify's GUI #776

Closed pfebrer closed 4 months ago

pfebrer commented 4 months ago

The idea is that sisl-gui (https://github.com/pfebrer/sisl-gui) will disappear in favour of a GUI that is general for nodify. This GUI can be launched in the terminal with 

nodify-gui

once nodify is installed.

Then, the only thing sisl-specific (for now) are the options that sisl provides for plotting files. These are registered once sisl is nodified, because sisl.__nodify__() will be called.

Then, to use sisl functionality on nodify's GUI one only needs to pass sisl on the list of modules:

nodify-gui sisl

This will result in what previously was sisl-gui.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 87.30%. Comparing base (be29de5) to head (628246c).

Files Patch % Lines
src/sisl/_nodify.py 13.04% 20 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #776 +/- ## ========================================== - Coverage 87.34% 87.30% -0.04% ========================================== Files 393 394 +1 Lines 50385 50409 +24 ========================================== + Hits 44007 44011 +4 - Misses 6378 6398 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.