Closed pfebrer closed 1 month ago
Attention: Patch coverage is 0%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 66.25%. Comparing base (
2b299e3
) to head (1c5596d
).
Files | Patch % | Lines |
---|---|---|
src/sisl/viz/figure/matplotlib.py | 0.00% | 4 Missing :warning: |
src/sisl/viz/processors/bands.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@pfebrer this one fails CI, bands.py: L132, KeyError.
Can you add "dash": "solid"
to the default styles here? https://github.com/zerothi/sisl/blob/58f4758438a66f598e6140826a87571c3e047c12/src/sisl/viz/processors/bands.py#L101
I forgot, that should solve it.
done!
This commit also makes line dash work for the matplotlib backend
One can now use the
"dash"
key inbands_style
, as in all other line style specifications in the viz module: