search

zerotier / install.zerotier.com

Source for https://install.zerotier.com curl|bash installer
https://install.zerotier.com
BSD 3-Clause "New" or "Revised" License
58 stars 41 forks source link

Installer not identifying Rocky Linux as equivalent to RHEL #23

Closed timroster closed 1 month ago

timroster commented 2 years ago

What you expect to happen

When running the installer on Rocky Linux, it would determine that it should have a similar yum repo endpoint as CentOS/RHEL

What is actually happening

The installer does not recognize Rocky Linux as CentOS/RHEL equivalent and falls back to generic el7 rpm yum config. With 1.8.5 this causes the installation to proceed, but the zerotier applications fail in finding a dependent library unless it is previously installed:

https://github.com/zerotier/ZeroTierOne/issues/1575#issuecomment-1059585373

Steps to reproduce the error

Start with a current Rocky Linux 8.5 system and run:

curl -s https://install.zerotier.com | sudo bash
zerotier-cli join <valid-network-id>

Recommended fix

Update installer script to match Rocky and configure an identical yum repo as CentOS/RHEL

timroster commented 2 years ago

I did some diffs on the install.sh.in file in this repo and it's not the same as what currently comes from the https://install.zerotier.com site. So in place of a PR - the line containing the matching logic could be updated to look something like:

    elif [ -n "`cat /etc/redhat-release 2>/dev/null | grep -i centos`" -o -n "`cat /etc/redhat-release 2>/dev/null | grep -i enterprise`" -o -n "`cat /etc/redhat-release 2>/dev/null | grep -i rocky`" ]; then

to fix the issue.