This makes it so if clang-format detects any misformatted code, it fails. Then it skips doing the builds.
I noticed that if I run make fmt, it makes a bunch of changes to the current file. So formatting is already out of sync with what we want (based on .clang-format).
User can then run make fmt and re push to fix. The logs say Please run make fmt and resubmit when it fails.
Could add some clang-tidy steps or whatever later.
It's possible to have gh-action automatically re-format for you, but it looks like a pain to set up.
totally fine if no one else wants this. just reject.
someone will have to run make fmt and commit after this; but i'm assuming jh has other cpp changes so i'm not doing it here.
joseph-henry
commented
1 year ago
This makes it so if
clang-formatdetects any misformatted code, it fails. Then it skips doing the builds. I noticed that if I runmake fmt, it makes a bunch of changes to the current file. So formatting is already out of sync with what we want (based on .clang-format).User can then run
make fmtand re push to fix. The logs sayPlease run make fmt and resubmitwhen it fails.Could add some clang-tidy steps or whatever later.
It's possible to have gh-action automatically re-format for you, but it looks like a pain to set up.
totally fine if no one else wants this. just reject.
someone will have to run
make fmtand commit after this; but i'm assuming jh has other cpp changes so i'm not doing it here.