Closed keepwn closed 2 years ago
Hmm! I might have gotten this wrong; I'll review later this week when I go over the other outstanding patches.
Patch looks good; I took the liberty of moving your unwrap to a try (?
) expression so it bubbles the error instead of crashing the program. I also rebased against recent main.
I'm running tests now, then will probably merge. Thanks for this!
As mentioned in the README, we should choose
Resolver::from_system_conf()
that using conf from/etc/resolv.conf
notResolverConfig::default()
that using 8.8.8.8/8.8.4.4.