0.4.1 has multiple building issues

[devvick]

1. The Cargo.lock is not updated, so --locked can't be used with cargo build:

   error: the lock file (...)/zeronsd-0.4.1/Cargo.lock needs to be updated but --locked was passed to prevent this
   If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.
   

   This makes the package non-reproducible, because it forces the builder to update the dependencies with cargo update on every build. More info: https://wiki.archlinux.org/title/Rust_package_guidelines#Prepare

2. If the deps are updated, one of the subsequent tests fails:

   running 9 tests
   test tests::test_central_token ... ok
   test tests::test_central_token_panic - should panic ... ok
   test tests::test_domain_or_default ... ok
   test tests::test_parse_ip_from_cidr ... ok
   test tests::test_supervise_systemd_green ... FAILED
   test tests::test_parse_hosts_duplicate ... ok
   test tests::test_supervise_systemd_red ... ok
   test tests::test_parse_hosts ... ok
   test tests::test_parse_member_name ... ok
   

failures:

---- tests::test_supervise_systemd_green stdout ---- thread 'tests::test_supervise_systemd_green' panicked at 'assertion failed: (left == right) left: "\n[Unit]\nDescription=zeronsd for network 1234567891011121\nRequires=zerotier-one.service\nAfter=zerotier-one.service\n\n[Service]\nType=simple\nExecStart=zeronsd start -t /proc/cpuinfo 1234567891011121\nTimeoutStopSec=30\nRestart=always\n\n[Install]\nWantedBy=default.target\n", right: "\n[Unit]\nDescription=zeronsd for network 1234567891011121\nRequires=zerotier-one.service\nAfter=zerotier-one.service\n\n[Service]\nType=simple\nExecStart=zeronsd start -t /proc/cpuinfo 1234567891011121\nTimeoutStopSec=30\n\n[Install]\nWantedBy=default.target\n": basic', src/tests.rs:171:13

failures: tests::test_supervise_systemd_green

test result: FAILED. 8 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s

error: test failed, to rerun pass '--lib'

[erikh]

I replied but the email didn't go through I guess. I'm working on this now.

[erikh]

@devvick can you please retry with latest main?

[erikh]

I also added the lib tests to our CI so this should not happen in the future.

[devvick]

The errors are from the latest Release (https://github.com/zerotier/zeronsd/releases), and as such prevent me from updating this package: https://aur.archlinux.org/packages/zeronsd

The latest main is fetched in another type of package: https://aur.archlinux.org/packages/zeronsd-git which builds OK. So until there's a new versioned release, the package zeronsd in the AUR will have to stay at v.0.4.0

[erikh]

Yep, give me a bit. I just wanted you to test it before I kicked out the latest rev.

0.4.2 will be out within the hour. Sorry for the inconvenience, and thank you for maintaining the arch package!

[erikh]

0.4.0 has a systemd bug which is important to note, so you'll want to push people to 0.4.2 asap.

[erikh]

@devvick please validate 0.4.2 does what you need, then close this ticket. I'd appreciate it as it's 4:30am here. I'm pretty exhausted now.

[devvick]

The package builds fine now. I've updated the AUR entry to 0.4.2

[erikh]

Thanks for your diligence here; sorry for the trouble. Have a great night!

[erikh]

Crap. I'm on this, give me a little bit. Thanks for the heads up.

-Erik

------- Original Message ------- On Saturday, April 2nd, 2022 at 2:16 AM, devvick @.***> wrote:

• The Cargo.lock is not updated, so --locked can't be used with cargo build:

error

:

the lock file (...)/zeronsd-0.4.1/Cargo.lock needs to be updated but --locked was passed to prevent this If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.

This makes the package non-reproducible, because it forces the builder to update the dependencies with cargo update on every build. More info: https://wiki.archlinux.org/title/Rust_package_guidelines#Prepare

• If the deps are updated, one of the subsequent tests fails:

running 9 tests test tests::test_central_token ... ok test tests::test_central_token_panic - should panic ... ok test tests::test_domain_or_default ... ok test tests::test_parse_ip_from_cidr ... ok test tests::test_supervise_systemd_green ... FAILED test tests::test_parse_hosts_duplicate ... ok test tests::test_supervise_systemd_red ... ok test tests::test_parse_hosts ... ok test tests::test_parse_member_name ... ok

failures:

---- tests::test_supervise_systemd_green stdout ---- thread 'tests::test_supervise_systemd_green' panicked at 'assertion failed: (left == right) left: "\n[Unit]\nDescription=zeronsd for network 1234567891011121\nRequires=zerotier-one.service\nAfter=zerotier-one.service\n\n[Service]\nType=simple\nExecStart=zeronsd start -t /proc/cpuinfo 1234567891011121\nTimeoutStopSec=30\nRestart=always\n\n[Install]\nWantedBy=default.target\n", right: "\n[Unit]\nDescription=zeronsd for network 1234567891011121\nRequires=zerotier-one.service\nAfter=zerotier-one.service\n\n[Service]\nType=simple\nExecStart=zeronsd start -t /proc/cpuinfo 1234567891011121\nTimeoutStopSec=30\n\n[Install]\nWantedBy=default.target\n": basic', src/tests.rs:171:13

failures: tests::test_supervise_systemd_green

test result: FAILED. 8 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s

error

:

test failed, to rerun pass '--lib'

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>