zeroturnaround / maven-jrebel-plugin

Generates rebel.xml configuration file for the maven project
Apache License 2.0
51 stars 23 forks source link

Maven 3.9.2 is signalling (forward compatibility) issues for jrebel-maven-plugin 1.1.11 #22

Open aikebah opened 1 year ago

aikebah commented 1 year ago

Verbose validation results with Maven 3.9.2:

[WARNING]
[WARNING]  * org.zeroturnaround:jrebel-maven-plugin:1.1.11
[WARNING]   Declared at location(s):
[WARNING]    *** REDACTED ***
[WARNING]   Used in module(s):
[WARNING]    *** REDACTED ***
[WARNING]   Plugin issue(s):
[WARNING]    * Plugin is a Maven 2.x plugin, which will be not supported in Maven 4.x
[WARNING]    * Plugin mixes multiple Maven versions: [3.0, 2.0.6]
[WARNING]    * Plugin should declare these Maven artifacts in `provided` scope: [org.apache.maven:maven-settings-builder:3.0, org.apache.maven:maven-repository-metadata:3.0, org.apache.maven:maven-artifact:3.0, org.apache.maven:maven-plugin-api:3.0, org.apache.maven:maven-settings:3.0, org.apache.maven:maven-aether-provider:3.0, org.apache.maven:maven-model:3.0, org.apache.maven:maven-core:3.0, org.apache.maven:maven-model-builder:3.0]
[WARNING]    * Plugin depends on plexus-container-default, which is EOL
[WARNING]
[WARNING]
[WARNING] Fix reported issues by adjusting plugin configuration or by upgrading above listed plugins. If no upgrade available, please notify plugin maintainers about reported issues.
akuusik-perforce commented 1 year ago

@aikebah , could you add the command line here, so I could use it to verify that the issues are gone?

aikebah commented 1 year ago

@akuusik-perforce A simple mvn org.zeroturnaround:jrebel-maven-plugin:1.1.11:generate will do as a validator that you use the proper maven version (maven 3.9.2 required as the validations were put in that version), result will be a brief message indicating that 1.11.0 has issues, add -Dmaven.plugin.validation=VERBOSE for the full details like above. If you don't get the message it means you're not running it on maven 3.9.2

When substituting 1.11.0 by the new snapshot version of your modified plugin the message should be gone (or will indicate in verbose mode what violations for maven 4 compatibility are still present)

aikebah commented 1 year ago

@akuusik-perforce Ran a test myself as well on a build from the HEAD commit of master and can confirm that the issues reported by Maven for forward compatibility have now been resolved.