search

zerovm / zerocloud

Swift middleware for Zerocloud
Apache License 2.0
53 stars 14 forks source link

remove some sysimage_devices checks #147

Closed pkit closed 10 years ago

pkit commented 10 years ago

this patch removes some redundant checks from ClusterController sysimages are resolved on objectquery middleware, no need to sanity check it on proxyquery

mgeisler commented 10 years ago

With a change like this, it would be very convincing for me as a reviewer if there had been no change in the test output when you remove the checks you claim to be redundant. That is, to demonstrate that they are truly redundant, you should not need to update the test output.

pkit commented 10 years ago

Yep, I thought about it, but it will look kind of ugly without this change. System images do not have path, which mean that objectquery will produce confusing message when it will encounter image that is not actually in system image list. So, the error message was changed to better represent path = None cases.

mgeisler commented 10 years ago

Okay, thanks! I'll merge it then