zertosh / jquery-audit

jQuery Audit
MIT License
563 stars 26 forks source link

Data: "@(undefined)" #9

Open jamesjessian opened 9 years ago

jamesjessian commented 9 years ago

Hi, Great extension. However, for all elements the jQuery Audit displays... Data: "@(undefined)" But using $($0).data() in the console shows me that the data object for this element has stuff in it. Any ideas?

zertosh commented 9 years ago

What version of jQuery? And do you have a site I can test it on?

jamesjessian commented 9 years ago

Sorry, no, I don't have a public site to test it on at the moment, but the version of jQuery we are using is 2.1.4. If you can't repeat the problem, I'll try and provide a public-accessible example.

zertosh commented 9 years ago

I looked into this. So jQuery Audit doesn't actually call $(el).data() – it does some other trickery because that method used to result in jQuery creating an empty internal data object on the first call for each node it was called on. It seems that at some point that changed, so that's no longer the case.

I don't have the bandwidth these days (I don't even use jQuery anymore) to fix this. Though, I welcome a PR that fixes via some form of version detection.