search

zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

Remove unnecessary php functions #136

Closed BenjaminHae closed 7 years ago

BenjaminHae commented 7 years ago

This PR removes unnecessary php functions and contains an upgrade script to upgrade existing installations. Please create a backup beforehand.

I'm sorry this PR looks like it changed everything. I made the mistake of formatting the code. Most lines are still the same.

zeruniverse commented 7 years ago

Let me take a look before you merge

On Sun, Mar 12, 2017 at 10:23 AM Benjamin Häublein notifications@github.com wrote:

This PR removes unnecessary php functions and contains an upgrade script to upgrade existing installations. Please create a backup beforehand.

I'm sorry this PR looks like it changed everything. I made the mistake of formatting the code. Most lines are still the same.

You can view, comment on, or merge this pull request online at:

https://github.com/zeruniverse/Password-Manager/pull/136 Commit Summary

  • removed encryption
  • removed encryption from initial
  • fixed syntax
  • syntax error
  • fix typo
  • fixed columns
  • fix variable
  • syntax
  • variable
  • fix columns
  • fix columns
  • correct update script
  • syntax
  • fix filepath
  • error handling?
  • fixed column name
  • fixed where clause
  • fix UPDATE
  • fix update
  • fix column name
  • created folder for upgrade script

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/pull/136, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNPPHlNqyfGel7ZCPgY-a1EcFwaB3ks5rlCougaJpZM4Mamqx .

BenjaminHae commented 7 years ago

Sure, just merge it when you are ready.

zeruniverse commented 7 years ago

Why this file is necessary?

upgrade/9.13_removeEncryption.php

BenjaminHae commented 7 years ago

It's an upgrade mechanism for existing installations. I can't expect every user to export their data and reimport it.

zeruniverse commented 7 years ago

Umm it's better to put it in release rather than in main repo.

On Sun, Mar 12, 2017 at 10:57 PM Benjamin Häublein notifications@github.com wrote:

It's an upgrade mechanism for existing installations. I can't expect every user to export their data and reimport it.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/pull/136#issuecomment-286021601, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNPLHql-3DumL7rqMox2FiDUA3JMIks5rlNq6gaJpZM4Mamqx .

BenjaminHae commented 7 years ago

As long as it is somewhere I'm happy :)

On 13 Mar 2017 7:19 a.m., "Jeffery Zhao" notifications@github.com wrote:

Umm it's better to put it in release rather than in main repo.

On Sun, Mar 12, 2017 at 10:57 PM Benjamin Häublein < notifications@github.com> wrote:

It's an upgrade mechanism for existing installations. I can't expect every user to export their data and reimport it.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/pull/136#issuecomment- 286021601, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNPLHql- 3DumL7rqMox2FiDUA3JMIks5rlNq6gaJpZM4Mamqx .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/pull/136#issuecomment-286024075, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCzsadQQwHCHMSJrT5Rvt6STKrlLi9Eks5rlOAHgaJpZM4Mamqx .

BenjaminHae commented 7 years ago

Just thought about something: When it's part of the release it should probably be part of the repository so it can a) be tested by anyone before release and b) can easily be found for newer releases when someone skips a version.

zeruniverse commented 7 years ago

I mean, this is not a part of the new release. It's somehow like a tool. So I think it should be an attachment of the release note.

On Mon, Mar 13, 2017 at 10:06 AM Benjamin Häublein notifications@github.com wrote:

Just thought about something: When it's part of the release it should probably be part of the repository so it can a) be tested by anyone before release and b) can easily be found for newer releases when someone skips a version.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/pull/136#issuecomment-286174121, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNNBoJGGtY8ss_tiS-KqI-56ns2O9ks5rlXeKgaJpZM4Mamqx .

BenjaminHae commented 7 years ago

I think the same applies to initial.sql ;) But I get your point. Just remove it from the pull request and add it to the next release. (I don't know if you are able to edit the PR - if you can't I'll remove the file.)