search

zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

added showDetails Plugin Hook #146

Closed BenjaminHae closed 7 years ago

zeruniverse commented 7 years ago

Bug introduced by this commit: https://travis-ci.org/zeruniverse/Password-Manager

zeruniverse commented 7 years ago

I'll draft a new version and jointly test it with the plugin on Chrome store.

Do you have any other things to merge in?

BenjaminHae commented 7 years ago

I don't get the error travis shows. I didn't change src/rest/password.php. And the error appears in line 50. The file is shorter than that. I think there is something wrong in travis...

I'd like to rename the passwordlastchangtime_01_system field to something like _system_PasswordLastChangeTime and hide all fields starting with _ on principle. That way the code doesn't need to be specific for fields that should be hidden. As there is a plugin system now the usage of such fields could become more widespread.

zeruniverse commented 7 years ago

OK I can do that

On Mon, Apr 3, 2017 at 9:25 AM Benjamin Häublein notifications@github.com wrote:

I don't get the error travis shows. I didn't change src/rest/password.php. And the error appears in line 50. The file is shorter than that. I think there is something wrong in travis...

I'd like to rename the passwordlastchangtime_01_system field to something like _systemPasswordLastChangeTime and hide all fields starting with on principle. That way the code doesn't need to be specific for fields that should be hidden. As there is a plugin system now the usage of such fields could become more widespread.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/pull/146#issuecomment-291195898, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNBBQcKt5LlnbZH0P8GX4TYkX6Ukeks5rsR2VgaJpZM4Mw2pt .

BenjaminHae commented 7 years ago

if you're not already on it I'd implement it this evening (in about 3h).

zeruniverse commented 7 years ago

Ok. I'm not on it yet On Mon, Apr 3, 2017 at 10:19 AM Benjamin Häublein notifications@github.com wrote:

if you're not already on it I'd implement it this evening (in about 3h).

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/pull/146#issuecomment-291211459, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNBXMk8dHM-MONoYpmK6hx_wMBd1eks5rsSo-gaJpZM4Mw2pt .