search

zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

Unable to export CSV #150

Closed zeruniverse closed 7 years ago

zeruniverse commented 7 years ago

Try here: https://pas.jeffery.cc/

zeruniverse commented 7 years ago

I deployed the master branch on my server. It seems your latest few commits break some stuffs.

zeruniverse commented 7 years ago

v9.13 has the same bug

zeruniverse commented 7 years ago

I think it's caused by $.getScript( 'js/lib/jquery.csv.js', function()

https://github.com/zeruniverse/Password-Manager/blob/master/src/js/main.js#L921

The Content-Security-Policy blocks this line.

BenjaminHae commented 7 years ago

Sounds logical. I'll look into it.

zeruniverse commented 7 years ago

I think we can make a new page for this

zeruniverse commented 7 years ago
BenjaminHae commented 7 years ago

I thought about that too (and would very much like this solution). But I think this would take some time to implement because then we should do some refactoring so we wouldn't have too much duplicated code.

The simplest short term solution would be to load the file using the <script> tag:

<script type="text/javascript" src="js/lib/jquery.csv.js"></script>
zeruniverse commented 7 years ago

I can do this. Please fix other two bugs

On Tue, Apr 4, 2017 at 8:40 AM Benjamin Häublein notifications@github.com wrote:

I thought about that too (and would very much like this solution). But I think this would take some time to implement because then we should do some refactoring so we wouldn't have too much duplicated code.

The simplest short term solution would be to load the file using the

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .
zeruniverse commented 7 years ago

The simple solution is not good. This feature is seldomly used but the JS file is 30K+ in size

BenjaminHae commented 7 years ago

How about we move the csv export to recovery.php? That way we discourage users from doing a cleartext backup while still offering a way to do so?

zeruniverse commented 7 years ago

Yes this is a good idea.

On Tue, Apr 4, 2017 at 9:20 AM Benjamin Häublein notifications@github.com wrote:

How about we move the csv export to recovery.php? That way we discourage users from doing a cleartext backup while still offering a way to do so?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/issues/150#issuecomment-291553320, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNN1Li8-bUSQqpV6GVr8X0hnyRmshks5rsm3WgaJpZM4MyX45 .

zeruniverse commented 7 years ago

Import_csv has the same problem