search

zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

Refactoring #192

Closed BenjaminHae closed 6 years ago

BenjaminHae commented 6 years ago

No functionality changes with this PR.

This is the first result of a larger progress toward cleaner code.

All rest functions now return json. Errors are always returned using the same functions (this reduces overhead in the frontend).

Javascript is refactored a lot for better readability. (Hoping for style CI for javascript to be released) I've used sonarqube for identifying problematic parts within our code. It found some functions that were very complicated to read. I've tried to break these up into logical smaller parts.

The ultimate goal is to have a separation between logic and representation. This should make implementing new features and fixing bugs a lot easier.

BenjaminHae commented 6 years ago

I'm currently doing very good progress on the separation of logic and representation. So I'll close this PR and reopen another one when I'm done. So we only have to do heavy testing in the end.

BenjaminHae commented 6 years ago

If someone is interested in what I'm doing, it's here: https://github.com/BenjaminHae/Password-Manager/tree/refactoringDesiredState

I really appreciate comments and ideas.