search

zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

PHP Fatal error: Arrays are not allowed as constants #206

Closed zeruniverse closed 6 years ago

zeruniverse commented 6 years ago

[Wed Jul 25 06:22:14.702426 2018] [:error] [pid 10018] [client 127.0.0.1:45772] PHP Fatal error: Arrays are not allowed as constants in /home/project-web/phppasswordmanager/htdocs/function/ajax.php on line 26, referer: https://phppasswordmanager.sourceforge.io/

Constant array is only supported for PHP 5.6+. Is there any alternative implementation that comply with older version PHP?

BenjaminHae commented 6 years ago

We can just remove the const keyword for the demo.

BenjaminHae commented 6 years ago

We explicitly need php 5.5+ for pbkdf, there must be a way to deploy the application to sourceforge with a newer php version. Especially since 5.4 and 5.5 are not supported anymore.

zeruniverse commented 6 years ago

We stated PHP 5.5+ is needed but const array is not available until 5.6. Sourceforge uses 5.4 and I commented out pbkdf

On Wed, Jul 25, 2018 at 8:51 AM Benjamin Häublein notifications@github.com wrote:

We explicitly need php 5.5+ for pbkdf, there must be a way to deploy the application to sourceforge with a newer php version. Especially since 5.4 and 5.5 are not supported anymore.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/issues/206#issuecomment-407803048, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNOqsXDmJnf8pkw_yFg8NQ7SJdAm5ks5uKJPogaJpZM4VfiNC .

BenjaminHae commented 6 years ago

Mh, weird that the ci checks don't fail on php 5.5...

zeruniverse commented 6 years ago

http://php.net/manual/en/language.constants.syntax.php

zeruniverse commented 6 years ago

Ok Let’s change php requirement to >5.6