History page failed to log user IP at demo site

[zeruniverse]

Is it a common issue?

[BenjaminHae]

Huh that's funny. Haven't seen that before. Maybe there's a reverse proxy involved? I've not changed the way the ip address is read:

• https://github.com/zeruniverse/Password-Manager/blob/9.15/src/rest/check.php
• https://github.com/zeruniverse/Password-Manager/blob/10.00/src/rest/check.php

@Pofilo can you reproduce this?

[zeruniverse]

Is this happening at your server?

On Wed, Jul 25, 2018 at 9:21 AM Benjamin Häublein notifications@github.com wrote:

Huh that's funny. Haven't seen that before. Maybe there's a reverse proxy involved? I've not changed the way the ip address is read:

- https://github.com/zeruniverse/Password-Manager/blob/9.15/src/rest/check.php

https://github.com/zeruniverse/Password-Manager/blob/10.00/src/rest/check.php

@Pofilo https://github.com/Pofilo can you reproduce this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/issues/209#issuecomment-407813056, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNOuNqHM9FFH8zL8Lf41v4YWEgvEUks5uKJrygaJpZM4VgYtu .

[BenjaminHae]

On my server everything looks as it should. Do you have phpinfo available on the system in question? If so could you please check the contents of $_SERVER['HTTP_X_FORWARDED_FOR']?

[Pofilo]

@BenjaminHae, I already experienced that on the demo. At least one year ago for sure ! I thought it was the configuration + the sourceforge environment ..

History with 10.00 works for me (apache, no special configuration).

[zeruniverse]

https://phppasswordmanager.sourceforge.io/info.php

On Wed, Jul 25, 2018 at 9:22 AM Benjamin Häublein notifications@github.com wrote:

On my server everything looks as it should. Do you have phpinfo available on the system in question? If so could you please check the contents of $_SERVER['HTTP_X_FORWARDED_FOR']?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/issues/209#issuecomment-407813651, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNGUtk529ycdgBmw5fuFthlGBGWEIks5uKJtggaJpZM4VgYtu .

[BenjaminHae]

Yup there's a reverse proxy. I'll fix it.

[BenjaminHae]

Should be fixed now.