zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

Import issue #220

Closed puntaschoice closed 5 years ago

puntaschoice commented 5 years ago

Been having trying to import similar data from PPMA into Password-Manager, as its a bit vague as to what the correct or acceptable column names of a CSV file should be. Trying to export to see what is expected, seems just as bad as I have yet to figure out where on the "recovery" screen Im supposed to be able to export data - but that aside...

Is it possible on the import screen to show what fields are acceptable / available? screenshot_20180923_181118

Otherwise all looks very good, so many thanks. Clifford

zeruniverse commented 5 years ago

https://github.com/zeruniverse/Password-Manager/wiki/Import

puntaschoice commented 5 years ago

Yes I read that before starting. I just presented with an error along lines "Something went wrong", hence why I was saying if it actually produced a listing of what fields are active, I would stand a chance of knowing if the fields required are those defined as nicely readable or the col-name etc

zeruniverse commented 5 years ago

It’s pretty weird. I think all unused fields will be ignored. Let me investigate it.

On Sun, Sep 23, 2018 at 1:25 PM Clifford Bradbury notifications@github.com wrote:

Yes I read that before starting. I just presented with an error along lines "Something went wrong", hence why I was saying if it actually produced a listing of what fields are active, I would stand a chance of knowing if the fields required are those defined as nicely readable or the col-name etc

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/issues/220#issuecomment-423832662, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNBTsPdYQrXZSQrUTxh2NvXIrDVTSks5ud8QWgaJpZM4W1ydh .

BenjaminHae commented 5 years ago

Could you provide a sample file?

BenjaminHae commented 5 years ago

Exporting data consists of three steps:

  1. Creating a backup file (When logged in: Settings->Back Up)
  2. Start the recovery process using this file
  3. Export CSV
BenjaminHae commented 5 years ago

I think I know what the problem is: The delimiter for the csv file must be ; for importing. I just added this prerequisite in the wiki.

puntaschoice commented 5 years ago

I have just been spinning up a new server to test it all again. Yes on V10, the backup instruction do now give as suggested by BenjaminHae, Im pretty sure when I was testing this before, it told me I would have to goto the login screen, but now clearly does allow to generate an encrypted file from Settings/Backup

I would have thought a CSV file would use comma's for delimiters as the C, would suggest than semicolon's?

So is it possible to not only have an update to show which fields are available but a prompt or selection of delimiters a s a feature suggestion?

I have tried again, and when editing import file with the header also changed , to ; I seem to have some success. name;url;comment;tags;username;password "Facebook - GV";"http://facebook.com/";"Comment1";"Tag1,Tag2";"a@g.com";"ABC123!"

Maybe a bit of overkill on the quotes, as my first run did work with mix of some field in quotes and not.

Thanks for that

zeruniverse commented 5 years ago

I think for CSV delimiters we use a plugin... Not sure how hard it is to let it support ,.

and yes, we will consider to add the avaliable columns under the import pop up.

zeruniverse commented 5 years ago

Btw, currently, you can go settings -> customize fields to look for avaliable fields. they are labels.

zeruniverse commented 5 years ago

@BenjaminHae I found this: https://github.com/zeruniverse/Password-Manager/blob/master/src/js/main.js#L73

Is it possible to let the import function to support both ',' and ';' as separator?

Something like:

try:
    var accarray = $.csv.toObjects(csv, {separator: ";"});
    if len(accarray)==0:
          var accarray = $.csv.toObjects(csv, {separator: ","});
except:
    var accarray = $.csv.toObjects(csv, {separator: ","});

And can you add all labels to the import popup (modal)? The codes are all in jQuery now but I'm not an expert on jQuery...

BenjaminHae commented 5 years ago

I was planning to take a look at it. I hope there is a way to automatically determine the separator. I'll also add the valid fields.

zeruniverse commented 5 years ago

I don’t think there’s a fully automation. You can create a file with , as data and ; as separator. I think try and catch should be good workaround tho.

On Thu, Oct 4, 2018 at 2:37 AM Benjamin Häublein notifications@github.com wrote:

I was planning to take a look at it. I hope there is a way to automatically determine the separator. I'll also add the valid fields.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/issues/220#issuecomment-426901954, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNEbSUObCecQuPEixoJYauynYbakLks5uhay2gaJpZM4W1ydh .

BenjaminHae commented 5 years ago

I've got some ideas for this that would add extra usability:

I'll do it when I have a clear picture in my mind.

zeruniverse commented 5 years ago

Thanks!

On Fri, Oct 5, 2018 at 12:40 PM Benjamin Häublein notifications@github.com wrote:

I've got some ideas for this that would add extra usability:

  • show column types available in the file
  • match columns to fields
  • guessing (or just trying) separators

I'll do it when I have a clear picture in my mind.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/issues/220#issuecomment-427427126, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNMzMznkCoD9J68kTPgmLJaMkAPOmks5uh4uXgaJpZM4W1ydh .

zeruniverse commented 5 years ago

is this done or need some additional work? i currently have some time to look into it.

BenjaminHae commented 5 years ago

I have not started yet, so If you have time it would be a really cool feature.

zeruniverse commented 5 years ago

close old issues