zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

[Enhancement] Update Bootstrap to version 4.2+ #234

Closed schams-net closed 4 years ago

schams-net commented 5 years ago

Problem

The application currently uses Bootstrap version 3.3.7. Further development on Bootstrap v3 has been stopped and a stable version of Bootstrap v4 was released in January 2018. The new version is a major rewrite from Bootstrapv 3 with significant changes and improvements.

Suggested Solution

Update Bootstrap to version 4.2 or newer.

Changes Required

Risks and Dependencies

Some JavaScript/CSS library currently used possibly depend on a specific version of Bootstrap. It needs to be assessed, if they are either compatible with Bootstrap v4 or need to be updated or replaced.

Additional Notes

It is assumed, it is ok, if the Bootstrap files are included into the web interface by using their external reference (typically a CDN such as stackpath.bootstrapcdn.com and/or cloudflare.com). Subresource Integrity (SRI) should be used as a security feature in this case.

Pofilo commented 5 years ago

Having external dependencies can be a real problem. For example on an instance which does not have access to the internet. My point is also valid for #233.

BenjaminHae commented 5 years ago

I'd be happy to accept a pr that changes the framework to bootstrap 4. But I strongly oppose loading any external resources.

schams-net commented 5 years ago

Understood your point re external resources. I am happy to have a look what is required to update Bootstrap to v4 and create a PR once completed and tested.

However, it makes sense to deal with that after #235 and #236 have been resolved (and are in master).

zeruniverse commented 4 years ago

Goto #248