search

zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

Positive comment and thank you #244

Closed CoderJason123 closed 5 years ago

CoderJason123 commented 5 years ago

You've made a very nice piece of code here. I can say this after looking at tons of projects related to open source password managers and being a developer for 20 years.

It was fun to play with php again in this way, and the ease of implementation and javascript vanilla approach is fantastic, as opposed to the approach that has thousands of libraries and challenging to use build tools.

As something fun, one of the fields you store might want to include the favicon from a website. Would look nice in the table.

I plan to monitor this project and perhaps someday do some pull requests, but right now I want to enjoy what you have created to share. Thank you.

BenjaminHae commented 5 years ago

Thank you!

zeruniverse commented 5 years ago

Thank you!

On Thu, Mar 21, 2019 at 10:51 PM Benjamin Häublein notifications@github.com wrote:

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/issues/244#issuecomment-475502492, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbvNMWoVWszdoDCFI7To1UESV-a0NpQks5vZG9HgaJpZM4cCkhh .

BenjaminHae commented 5 years ago

As something fun, one of the fields you store might want to include the favicon from a website. Would look nice in the table.

Btw. this should be pretty easy. Just take a look at the file src/js/plugins/linkButton.js. The nicer way to it would be to not only take the link, but also store the real favicon in the fields (privacy reasons) - this would be a bit harder.