search

zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

Import CSV failed. #249

Closed zeruniverse closed 4 years ago

zeruniverse commented 4 years ago

Hi @BenjaminHae, I found this piece of code is crashing csv import: https://github.com/zeruniverse/Password-Manager/blame/master/src/js/main.js#L73 because the separator at export is , instead of ;.

Btw, why export_raw dropped file support? https://github.com/zeruniverse/Password-Manager/blob/master/src/js/common/recoveryBackend.js#L152

BenjaminHae commented 4 years ago

I found this piece of code is crashing csv import: https://github.com/zeruniverse/Password-Manager/blame/master/src/js/main.js#L73 because the separator at export is , instead of ;.

Mh, that's weird. It should have guessed the separator from the data. But it's been a long time so I could be wrong.

Btw, why export_raw dropped file support? https://github.com/zeruniverse/Password-Manager/blob/master/src/js/common/recoveryBackend.js#L152

I have no idea ;)

BenjaminHae commented 4 years ago

I'm closing it as you've fixed everything. Is that ok?

zeruniverse commented 4 years ago

Cool. If you finished the new Password Manager, I can put it at top of README to redirect the traffic.

BenjaminHae commented 4 years ago

Thank you! It'll take a little more time. I'll publish it once the browser-plugin works :)