search

zeruniverse / Password-Manager

An online keepass-like tool to manage password. client-side AES encryption!
Other
170 stars 44 forks source link

Make all HTTP request filenames lowercase #265

Closed Frosty-J closed 2 years ago

Frosty-J commented 2 years ago

On server hosting that forces a particular case, Password Manager fails to work correctly, resulting in "Signup is not allowed." You may prefer to use dashes or something instead (this repository doesn't seem to strictly adhere to any particular naming convention) but, even if not merged, I hope this pull request can serve as a guide for anyone who may wish to use this on such a configuration. It's likely I missed something, but this is enough to get it working.

I also had trouble with importing data into the password manager, as my over a hundred rows resulted in insert.php being called over a hundred times, which triggered mod_evasive's denial-of-service protection. I was able to disable the module then import my data after determining why it started getting 403s. Grouping the import into a single request would solve this, and also ensure that the entries remain in the same order after importing (as the requests don't necessarily get processed in the order they're sent in).

zeruniverse commented 2 years ago

Thanks for this PR, i’ll sure take a look

On Mon, Jun 6, 2022 at 1:26 AM Frosty-J @.***> wrote:

On server hosting that forces a particular case, Password Manager fails to work correctly, resulting in "Signup is not allowed." You may prefer to use dashes or something instead (this repository doesn't seem to strictly adhere to any particular naming convention) but, even if not merged, I hope this pull request can serve as a guide for anyone who may wish to use this on such a configuration. It's likely I missed something, but this is enough to get it working.

I also had trouble with importing data into the password manager, as my over a hundred rows resulted in insert.php being called over a hundred times, which triggered mod_evasive's denial-of-service protection. I was able to disable the module then import my data after determining why it started getting 403s. Grouping the import into a single request would solve this, and also ensure that the entries remain in the same order after importing (as the requests don't necessarily get processed in the order they're sent in).

You can view, comment on, or merge this pull request online at:

https://github.com/zeruniverse/Password-Manager/pull/265 Commit Summary

File Changes

(20 files https://github.com/zeruniverse/Password-Manager/pull/265/files )

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/zeruniverse/Password-Manager/pull/265, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDO6NFRZGOGOXO7RXTFKXTVNTPNHANCNFSM5X5K33CQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

zeruniverse commented 2 years ago

@Frosty-J have you tested this change? Is everything running?

Frosty-J commented 2 years ago

I've not tested email functionality. The usual adding, deleting and updating of records I do works.