toggle button on splitter

zesik / react-splitter-layout

A simple split layout for React and modern browsers. https://zesik.com/react-splitter-layout

MIT License

428 stars 131 forks source link

toggle button on splitter #12

Closed Shawnfoto closed 6 years ago

Shawnfoto commented 6 years ago

This is a toggle button on splitter

zesik commented 6 years ago

Thanks for contributing!

Sorry for replying late. I had several busy months. Will review soon.

zesik commented 6 years ago

Hi,

I like the feature! But there are several things I would like to mention:

Could you fix linting problems and remove unnecessary blank lines?
Could you rename your methods to follow others' naming convention?
Could you keep using some gray colors? I prefer to leave fancy color config to user customization.
When click to show, the splitter goes back to initial position no matter whether its position was changed before hiding. By intuition, I'd prefer it restore to previous position. Could you do that as well?

Thanks

skrauselevy commented 6 years ago

@zesik, since @Shawnfoto has not responded to your requested changes and this PR is relevant to what I am working on would I be able to take over so this can get merged?

zesik commented 6 years ago

@Shawnfoto I'd like to move forward with this feature. Could you let me know whether you are still working on this before 12 June?

Shawnfoto commented 6 years ago

OK, can you help me remove it?

zesik commented 6 years ago

@Shawnfoto I see you are committing changes! Do you have plan to improve it?

If not, could you close the PR?

coveralls commented 4 years ago

Coverage decreased (-97.6%) to 2.411% when pulling 79825668644080d0fc4acbff7a38d4dc8d17e0e2 on Shawnfoto:master into 6807401c7cc95937fa8e6d14e10addaf21937a3e on zesik:master.